src/utils/FieldValueCollector.ts (2)

111-132: LGTM - Consider adding debug logging for troubleshooting.

The tag normalization correctly strips # prefixes and handles the untyped Obsidian API. The empty catch block at line 127-129 silently swallows errors, which is acceptable since the caller falls back to file-based collection. However, routing errors through the logger utility could aid debugging in production.

-	} catch {
-		// ignore and fall back to file-based collection
-	}
+	} catch (e) {
+		// Fall back to file-based collection; log for debugging
+		console.debug?.("collectAllVaultTags: vault tag index unavailable", e);
+	}

---

134-200: The batch processing and tag extraction from frontmatter (tags/tag) and inline hashtags (metadataCache.tags) are correctly implemented.

Minor design note: collectTagValues returns early when tags are found (line 72), which bypasses the manual collection path that would call InlineFieldParser.getFieldValues if filters.inline is true. This means Dataview-style inline fields like tags:: work would not be collected if vault or frontmatter tags exist. However, no search results show users combining |inline:true with tag fields, and this appears to be the intentional design where tags receive special-case handling rather than generic field handling.

src/utils/FieldValueCollector.issue671.test.ts (1)

10-31: Good regression test coverage for Issue #671.

The test correctly validates that vault tags are included in suggestions when no filters are present. The mock setup is appropriate, and clearing the cache before each test prevents cross-test contamination.

Consider adding edge case coverage:

it("uses file-based collection when filters are present", async () => {
	const app = new App();
	// @ts-expect-error - getTags exists in Obsidian but is not typed
	app.metadataCache.getTags = () => ({ "#vaultTag": 1 });
	app.vault.getMarkdownFiles = () => [];

	// With folder filter, should use file-based scan (empty result since no files)
	const values = await collectFieldValuesProcessed(app, "tags", { folder: "notes" });
	expect(values).not.toContain("vaultTag");
});

it("handles 'tag' field name (singular)", async () => {
	const app = new App();
	// @ts-expect-error
	app.metadataCache.getTags = () => ({ "#test": 1 });
	app.vault.getMarkdownFiles = () => [];

	const values = await collectFieldValuesProcessed(app, "tag", {});
	expect(values).toContain("test");
});

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: CR
Repo: chhoumann/quickadd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T21:20:52.398Z
Learning: Applies to tests/**/*.{ts,tsx} : Add regression coverage for bug fixes

Learnt from: CR
Repo: chhoumann/quickadd PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T21:20:52.398Z
Learning: Applies to src/**/*.{ts,tsx} : Structure production code so Obsidian dependencies are injected behind interfaces; unit tests target pure logic and swap in adapters or `tests/obsidian-stub.ts`